Skip to content

Add ETH override to tokenData API #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathanhleung wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ETH override to tokenData API #488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6927130
Add ETH override to tokenData API
nathanhleung Mar 6, 2022
cf55978
Add Ether override in try-catch
nathanhleung Mar 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions api/tokenData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ type tokenData = {
*
*/

// params: address (required), chainId (optional) (default 1)
export default async (request: VercelRequest, response: VercelResponse) => {
export default async function handler(request: VercelRequest, response: VercelResponse) {
response.setHeader("Access-Control-Allow-Origin", "*");
response.setHeader("Cache-Control", "max-age=3600, s-maxage=3600");

Expand Down Expand Up @@ -92,7 +91,10 @@ export default async (request: VercelRequest, response: VercelResponse) => {

let method: "RARI" | "COINGECKO" | "CONTRACT";

//1.) Try Rari Token list 2.) Try Coingecko 3.) Try contracts
// 1.) Try Rari Token list
// 2.) Check if the address is the zero address (denotes ETH)
// 3.) Try Coingecko
// 4.) Try contracts
if (!!rariTokenData) {
// We got data from rari token list
let { symbol: _symbol, name: _name, logoURI } = rariTokenData;
Expand All @@ -102,6 +104,10 @@ export default async (request: VercelRequest, response: VercelResponse) => {
logoURL = logoURI;

method = "RARI";
} else if (address === "0x0000000000000000000000000000000000000000") {
symbol = "ETH"; // We use the zero address in the dapp to denote ETH
name = "Ether";
logoURL = "https://icons.iconarchive.com/icons/cjdowner/cryptocurrency-flat/64/Ethereum-ETH-icon.png";
} else {
// We could not get data from rari token list. Try Coingecko
const coingeckoData = await fetch(coingeckoURL).then((res) => {
Expand Down