Skip to content

Add name to all tasks#43

Open
c-martinez wants to merge 2 commits intodevelopfrom
simName
Open

Add name to all tasks#43
c-martinez wants to merge 2 commits intodevelopfrom
simName

Conversation

@c-martinez
Copy link
Copy Markdown
Contributor

At the moment, tasks get an id generated by concatenating ensamble & simulation -- but ensamble & simulation do not always make sense.

I would suggest to add an identifying label (let's call it name), which gets added to the task. And I would also suggest to add it to every task automatically (without having to explicitly define name in the json file defining the simulation schema). This pull request implements those changes.

However, if accepted, sim-city-webservice would also need to be adjusted to auto-add name to the schema. More add the following lines here:

sim['form'].append('name')
sim['properties']['name'] = { "type": "string" }

@c-martinez c-martinez requested a review from bpmweel August 11, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant