Skip to content

Simplify Makefile#278

Merged
steliyan merged 1 commit into
mainfrom
ss/makefile
Jul 7, 2026
Merged

Simplify Makefile#278
steliyan merged 1 commit into
mainfrom
ss/makefile

Conversation

@steliyan

@steliyan steliyan commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Fixed

.PHONY was a variable assignment, not PHONY declaration (:= vs :).

  • Consistent @ usage - we want verbose output in the CI, no need to silence it (can be simulated with make -s)

Removed

  • GO_FILES - golangci-lint takes care of everything
  • coverage - we don't really track the coverage. If we decide to integrate it (or visualize it), we can bring it back.
  • vendor goal - no vendored dependencies
  • generate goal - no go:generate usage in the entire codebase
  • clean goal - not needed after removal of the test coverage
  • vet goal - already included in the golangci-run config
  • goimports goal - already included in the golangci-run config
  • count=1 - for CI it doesn't matter, locally we can use the cache

Renamed

  • Rename fmtcheck goal to lint
  • Rename all goal to ci

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@steliyan steliyan marked this pull request as ready for review July 7, 2026 15:15
@steliyan steliyan merged commit befa9dc into main Jul 7, 2026
3 checks passed
@steliyan steliyan deleted the ss/makefile branch July 7, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants