-
Notifications
You must be signed in to change notification settings - Fork 416
DispatchTimeInterval & Date: avoid 32-bit overflows, fix watchOS crashes
#2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NachoSoto
merged 2 commits into
watchos-tests
from
nacho/sdk-2974-crash-after-purchase-on-watchos
Mar 16, 2023
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
Tests/UnitTests/FoundationExtensions/DispatchTimeIntervalExtensionsTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| // | ||
| // Copyright RevenueCat Inc. All Rights Reserved. | ||
| // | ||
| // Licensed under the MIT License (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://opensource.org/licenses/MIT | ||
| // | ||
| // DispatchTimeIntervalExtensionsTests.swift | ||
| // | ||
| // Created by Nacho Soto on 3/16/23. | ||
|
|
||
| import Nimble | ||
| import XCTest | ||
|
|
||
| @testable import RevenueCat | ||
|
|
||
| // swiftlint:disable identifier_name | ||
|
|
||
| class DispatchTimeIntervalExtensionsTests: TestCase { | ||
|
|
||
| func testIsLessThan() { | ||
| let a: DispatchTimeInterval = .seconds(1) | ||
| let b: DispatchTimeInterval = .seconds(2) | ||
|
|
||
| expect(a) < b | ||
| } | ||
|
|
||
| func testIsGreaterThan() { | ||
| let a: DispatchTimeInterval = .seconds(2) | ||
| let b: DispatchTimeInterval = .seconds(1) | ||
|
|
||
| expect(a) > b | ||
| } | ||
|
|
||
| func testSecondsToMilliseconds() { | ||
| expect(DispatchTimeInterval.seconds(5).milliseconds) == 5_000 | ||
| } | ||
|
|
||
| func testSecondsToNanoseconds() { | ||
| expect(DispatchTimeInterval.seconds(5).nanoseconds) == 5_000_000_000 | ||
| } | ||
|
|
||
| func testAddingSeconds() { | ||
| let a: DispatchTimeInterval = .seconds(2) | ||
| let b: DispatchTimeInterval = .seconds(1) | ||
|
|
||
| expect(a + b) == .seconds(3) | ||
| } | ||
|
|
||
| func testAddingMilliseconds() { | ||
| let a: DispatchTimeInterval = .milliseconds(2) | ||
| let b: DispatchTimeInterval = .milliseconds(1) | ||
|
|
||
| expect(a + b) == .milliseconds(3) | ||
| } | ||
|
|
||
| func testAddingNanoseconds() { | ||
| let a: DispatchTimeInterval = .nanoseconds(2_000_000) | ||
| let b: DispatchTimeInterval = .nanoseconds(1_000_000) | ||
|
|
||
| expect(a + b) == .milliseconds(3) | ||
| } | ||
|
|
||
| func testSubstractingSeconds() { | ||
| let a: DispatchTimeInterval = .seconds(3) | ||
| let b: DispatchTimeInterval = .seconds(1) | ||
|
|
||
| expect(a - b) == .seconds(2) | ||
| } | ||
|
|
||
| func testSubstractingMilliseconds() { | ||
| let a: DispatchTimeInterval = .milliseconds(3) | ||
| let b: DispatchTimeInterval = .milliseconds(1) | ||
|
|
||
| expect(a - b) == .milliseconds(2) | ||
| } | ||
|
|
||
| func testSubstractingNanoseconds() { | ||
| let a: DispatchTimeInterval = .nanoseconds(3_000_000) | ||
| let b: DispatchTimeInterval = .nanoseconds(1_000_000) | ||
|
|
||
| expect(a - b) == .milliseconds(2) | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to keep using
NSDateanymore.