Fix/epub in the wild robustness#10
Merged
Merged
Conversation
Old EPUBs in the wild routinely violate the spec in ways that broke loading, parsing, or rendering. Make the parser and resource layers tolerant: - XHTML: escape stray `&`, remap HTML named entities to numeric refs, strip illegal XML control chars, preserve comments/CDATA — fixes strict-parser failures like "EntityRef: expecting ';'" and "PCDATA invalid Char value 31". - Images: index every image file in the archive (not just manifest items), tolerate unreadable manifest entries, and percent-decode href/zip lookups — fixes in-content illustrations rendering as broken/no-data. - OPF: default missing dc:title/language/identifier (with a warning) instead of throwing; structural <manifest>/<spine> checks stay strict. Verified across a 27-book corpus: every book loads, parses all chapters, and paginates, and every image that exists in the archive resolves.
Old EPUBs in the wild routinely violate the spec in ways that broke
loading,
parsing, or rendering. Make the parser and resource layers tolerant:
- XHTML: escape stray `&`, remap HTML named entities to numeric refs,
strip
illegal XML control chars, preserve comments/CDATA — fixes
strict-parser
failures like "EntityRef: expecting ';'" and "PCDATA invalid Char
value 31".
- Images: index every image file in the archive (not just manifest
items),
tolerate unreadable manifest entries, and percent-decode href/zip
lookups —
fixes in-content illustrations rendering as broken/no-data.
- OPF: default missing dc:title/language/identifier (with a warning)
instead of
throwing; structural <manifest>/<spine> checks stay strict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.