Optimize Montgomery to Edwards conversions#1308
Open
daxpedda wants to merge 1 commit intoRustCrypto:masterfrom
Open
Optimize Montgomery to Edwards conversions#1308daxpedda wants to merge 1 commit intoRustCrypto:masterfrom
daxpedda wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
daxpedda
changed the title
55 tasks
daxpedda
force-pushed
the
edward-isogeny
branch
6 times, most recently
from
173d682 to
5bed37e
Compare
daxpedda
force-pushed
the
edward-isogeny
branch
from
5bed37e to
985623b
Compare
Member
|
I'm a little confused what's happening here. The input and output types are both |
Contributor
Author
|
Indeed. As I was saying in the OP: this is currently only used in hash2curve. This PR just improves existing code, I didn't add this function. But #1306 properly exposes this function to users and the Montgomery to Edwards conversion. Alternatively we can just close this as this improvement is included in #1306. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Montgomery to Edwards isogeny mapping to a more optimized version.
Notably reducing inversions from two to one.
This is currently only used for hash2curve, which actually has a more optimized mapping I will add in a different PR. This functionality will however be used when adding Montgomery to Edwards conversions in #1306.