ed448-goldilocks: Scalar Serde implementation should match PrimeFields#1463
Open
daxpedda wants to merge 1 commit intoRustCrypto:masterfrom
Open
ed448-goldilocks: Scalar Serde implementation should match PrimeFields#1463daxpedda wants to merge 1 commit intoRustCrypto:masterfrom
ed448-goldilocks: Scalar Serde implementation should match PrimeFields#1463daxpedda wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
daxpedda
force-pushed
the
ed448-serde-scalar-panic
branch
from
16b9f1c to
fadd545
Compare
This was referenced Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
EdwardsScalarSerde encoding to match the encoding exposed viaPrimeField, so 57 bytes instead of 56.Replaced by #1471, this would just be a temporary stop-gap.