pkcs5: add belt-kwp support, tweak iv parsing in pbes2 - #2408
Draft
makavity wants to merge 2 commits into
Draft
Conversation
baloo
marked this pull request as draft
August 24, 2026 22:57
makavity
commented
Aug 26, 2026
Comment on lines
+544
to
+554
| /// Decode an IV/nonce of exactly `N` bytes from an `AlgorithmIdentifier`'s | ||
| /// OCTET STRING parameters. | ||
| fn decode_iv<const N: usize>(params: Option<AnyRef<'_>>) -> der::Result<[u8; N]> { | ||
| params | ||
| .ok_or_else(|| Tag::OctetString.value_error())? | ||
| .decode_as::<&OctetStringRef>()? | ||
| .as_bytes() | ||
| .try_into() | ||
| .map_err(|_| Tag::OctetString.value_error().into()) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Hey, @tarcieri!
What do you think about that approach?
Contributor
Author
There was a problem hiding this comment.
Maybe I should separate it into another PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need RustCrypto/key-wraps#98 to be merged, before this can be merged