fix(xml-formatter): recover from malformed XML in tool call parsing#6
Open
francisjervis wants to merge 1 commit into
Open
fix(xml-formatter): recover from malformed XML in tool call parsing#6francisjervis wants to merge 1 commit into
francisjervis wants to merge 1 commit into
Conversation
Add a recovery pass using clean_malformed_xml before failing, and return an empty list instead of raising on parse error. Prevents AgendaManager._process_qa_pair tasks from dying silently and leaving memory/subtopic-coverage state partially un-updated.
350fd00 to
9a7a2b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a recovery pass using
clean_malformed_xmlbefore failing, and return an empty list instead of raising on parse error.Problem
When the LLM returns structurally malformed XML (mismatched tags, stray angle brackets inside field values, etc.),
ET.fromstringraisesET.ParseError. This caused backgroundAgendaManager._process_qa_pairtasks to die silently, leaving memory/subtopic-coverage state partially un-updated.Changes (
src/utils/llm/xml_formatter.py)ParseError, runclean_malformed_xmlon the string and retry.[]so the calling interview continues unimpeded.