refactoring ipa tests for hostname framework changes.#8611
Open
danlavu wants to merge 1 commit intoSSSD:masterfrom
Open
refactoring ipa tests for hostname framework changes.#8611danlavu wants to merge 1 commit intoSSSD:masterfrom
danlavu wants to merge 1 commit intoSSSD:masterfrom
Conversation
danlavu
added
Tests
Trivial
Author
|
CI tests are going to fail, this patch relies on two other patches, which includes container changes. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors src/tests/system/tests/test_ipa.py to replace hardcoded hostnames and f-string host references with dynamic calls to client.net.hostname() and ipa.server. A bug was identified in the getent lookup within the user override test, where a hyphen was incorrectly added to the username, creating a mismatch with the defined login name and causing the test to fail.
danlavu
force-pushed
the
tests-ipa-hostname-refactor
branch
from
129b22d to
aeb69b3
Compare
danlavu
force-pushed
the
tests-ipa-hostname-refactor
branch
from
aeb69b3 to
5ddfef5
Compare
justin-stephenson
approved these changes
Apr 17, 2026
madhuriupadhye
approved these changes
Apr 20, 2026
Contributor
sssd-bot
force-pushed
the
tests-ipa-hostname-refactor
branch
from
5ddfef5 to
e742a9c
Compare
danlavu
force-pushed
the
tests-ipa-hostname-refactor
branch
from
e742a9c to
c7326b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.