-
Notifications
You must be signed in to change notification settings - Fork 9
Remove 6 unused packages #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,7 +74,7 @@ function mapEvent(properties) { | |
| startdatetime: startdatetime, | ||
| endDateTime: endDateTime, | ||
| isSameDay: startdatetime === endDateTime, | ||
| daysToGo: moment(startdatetime).diff(moment(today), 'days'), | ||
| daysToGo: moment(startdatetime, 'DD MMM YYYY').diff(moment(today, 'DD MMM YYYY'), 'days'), | ||
|
||
| technologycategory: properties.Category, | ||
| eventtype: properties.CalendarType, | ||
| presenter: properties.Presenter, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the direct
react-youtubedependency doesn’t actually removereact-youtubefrom the install, becausereact-lazy-youtubedepends on it (transitively). If the goal is to eliminatereact-youtubeentirely (for supply-chain / footprint reasons), you’ll need to also replace/removereact-lazy-youtubeor switch to a different embed solution.