Align trust mark handling with spec alignment#51
Open
s-hal wants to merge 54 commits intoSUNET:masterfrom
Open
Align trust mark handling with spec alignment#51s-hal wants to merge 54 commits intoSUNET:masterfrom
s-hal wants to merge 54 commits intoSUNET:masterfrom
Conversation
More logging.
More logging.
…ervice into draft43_trust_mark_evaluation
…ervice into draft43_trust_mark_evaluation
'scope' is not part of an OIDC RP's metadata but is for a OAUTH2 client.
Add logging.
…reak circular import
Add CLI utilities and Trust Mark tooling
…rdinate_statement.
Draft43 trust mark evaluation
s-hal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes redundant and unreachable expiration validation in TrustMark.verify() since time checks are already enforced by JsonWebToken.verify() via EXPError. It also tightens Trust Mark validation by enforcing sub matching (sub vs entity_id) and outer versus inner trust_mark_type consistency, and updates resolve to process spec-shaped dict entries in trust_marks and skip invalid marks without failing the resolve response.