Correct paths for ovmf code & vars files - #540
Conversation
| --virt-type kvm \ | ||
| --import \ | ||
| --boot uefi,loader=/usr/share/qemu/ovmf-x86_64-ms-code.bin,nvram.template=/usr/share/qemu/ovmf-x86_64-ms-vars.bin | ||
| --boot uefi,loader=/usr/share/qemu/ovmf-x86_64-ms-4m-code.bin,nvram.template=/usr/share/qemu/ovmf-x86_64-ms-4m-vars.bin |
There was a problem hiding this comment.
can we just remove the loader parameters alltogether?
is this addressing the SL 16.1 issue that Joe reported? a bit more rationale would be nice
There was a problem hiding this comment.
a bit more rationale would be nice
Agree. Aplogies. Updated the PR description.
is this addressing the SL 16.1 issue that Joe reported?
I'm not sure as I am on a Tumbleweed system, but him mentioning this on Slack and a call reminded me to fix this problem I had noticed long back.
There was a problem hiding this comment.
can we just remove the loader parameters alltogether?
I gave this a shot and VMs spun up just fine. There was a difference in the firmware file that libvirt chose, but in a conversation Gemini suggested it's best to leave it to libvirt to choose thsee files.
Sharing some snippets from virsh dumpxml <vm>:
Without loader and nvram arguments
<loader readonly='yes' type='pflash' format='qcow2'>/usr/share/qemu/ovmf-x86_64-ms-4m-code.qcow2</loader>
<nvram template='/usr/share/qemu/ovmf-x86_64-ms-4m-vars.qcow2' templateFormat='qcow2' format='qcow2'>/var/lib/libvirt/qemu/nvram/node01_VARS.qcow2</nvram>With the arguments
<loader readonly='yes' type='pflash' format='raw'>/usr/share/qemu/ovmf-x86_64-ms-4m-code.bin</loader>
<nvram template='/usr/share/qemu/ovmf-x86_64-ms-4m-vars.bin' templateFormat='raw' format='raw'>/var/lib/libvirt/qemu/nvram/node01_VARS.fd</nvram>Without arguments for iso output. It sets the loader.type and loader.readonly as we need:
<loader readonly='yes' type='pflash' format='qcow2'>/usr/share/qemu/ovmf-x86_64-ms-4m-code.qcow2</loader>
<nvram template='/usr/share/qemu/ovmf-x86_64-ms-4m-vars.qcow2' templateFormat='qcow2' format='qcow2'>/var/lib/libvirt/qemu/nvram/customize-iso_VARS.qcow2</nvram>Signed-off-by: Dharmit Shah <dharmit.shah@suse.com> Removed the `loader` and `nvram` arguments from `--boot` flag because without those libvirt is choosing the defaults that work just fine.
The files
ovmf-x86_64-ms-code.binandovmf-x86_64-ms-vars.binwere recently removed from Tumbleweed. However, cookbook still carries the now inexistent file paths which are removed in this PR because: