Fix Helm chart OCI paths - #545
Open
atanasdinov wants to merge 1 commit into
Open
Conversation
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
atanasdinov
marked this pull request as ready for review
July 28, 2026 10:08
ipetrov117
approved these changes
Jul 28, 2026
| // Use the full path for the chart identifier and drop the "repository" value. | ||
| // The latter is only valid for HTTP(s) repositories. | ||
| chart = fmt.Sprintf("%s/%s", repository, name) | ||
| chart, _ = url.JoinPath(repository, name) |
Contributor
There was a problem hiding this comment.
I wonder if this isn't silencing URL typos or similar errors. Isn't chart set to empty string on errors?
At this stage it is not clear to me if input values have been already sanitized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #492