Skip to content

Use model_release_date from leaderboard data in release date chart #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aorwall wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use model_release_date from leaderboard data in release date chart #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/analysis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
resolved: parseFloat(cb.getAttribute('data-resolved')) || 0,
cost: cost,
per_instance_details: fullModelData?.per_instance_details || null,
tags: fullModelData?.tags || null
tags: fullModelData?.tags || null,
model_release_date: fullModelData?.model_release_date || null
};
});
}
Expand Down
10 changes: 5 additions & 5 deletions js/charts/resolvedVsReleaseDateChart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
// Scatter chart for resolved % vs model release date
function renderResolvedVsReleaseDateChart(ctx, selected, colors, backgroundPlugin) {
// Filter models with release dates
// Filter models with release dates (prefer inline model_release_date, fallback to JS lookup)
const modelsWithDates = selected.filter(s => {
const releaseDate = getModelReleaseDate(s.tags);
return releaseDate !== null;
return s.model_release_date || getModelReleaseDate(s.tags);
});

if (modelsWithDates.length === 0) {
Expand Down Expand Up @@ -43,7 +42,7 @@ function renderResolvedVsReleaseDateChart(ctx, selected, colors, backgroundPlugi

// Prepare scatter data
const scatterData = modelsWithDates.map(s => {
const releaseDateInt = getModelReleaseDate(s.tags);
const releaseDateInt = s.model_release_date || getModelReleaseDate(s.tags);
const releaseDate = parseReleaseDateInt(releaseDateInt);
return {
x: releaseDate.getTime(),
Expand Down Expand Up @@ -139,7 +138,8 @@ function renderResolvedVsReleaseDateChart(ctx, selected, colors, backgroundPlugi
callbacks: {
label: (ctx) => {
const model = modelsWithDates[ctx.dataIndex];
const releaseDate = parseReleaseDateInt(getModelReleaseDate(model.tags));
const releaseDateInt = model.model_release_date || getModelReleaseDate(model.tags);
const releaseDate = parseReleaseDateInt(releaseDateInt);
const formattedDate = formatReleaseDate(releaseDate);
return `${model.name}: ${formattedDate}, ${ctx.parsed.y.toFixed(2)}%`;
}
Expand Down