(CHORE)[EX-3143] Upgrade protoc to 1.15.0 and protoc-go to 3.26.0 - #187
Merged
Conversation
- Alpine 3.15 → 3.21 - buf 1.8.0 → 1.66.0 - protoc/grpc from Alpine 3.21 community repo (protobuf v24.4, grpc 1.62.1) Split from upgrade/alpine-3.21-protobuf-v24 to unblock protoc-cpp build.
protoc-gen-workato@latest now requires go >= 1.24.0. Bump protoc-go version to 3.26.0.
- protoc base image: Alpine 3.15 -> 3.21, buf 1.8.0 -> 1.66.0 - protoc 3.18.1 -> 24.4, grpc 1.62.1 (from community repo) - protoc-cpp image: base protoc 1.14.2 -> 1.15.0 - Add abseil-cpp-dev and pkgconf build deps (required by protobuf v22+) - Regenerate wire_options.pb.cc/h during build to match container protobuf - Bump version to 1.13.0 - Fix legacy ENV format warning in Dockerfile Note: CRUX_CLIENT_RELEASE needs updating to a new s12-proto tag that includes the protobuf v24 string_view compatibility changes (see SafetyCulture/s12-proto PR upgrade/protobuf-v33-compatibility). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
In Alpine 3.21, grpc_cpp_plugin is in a separate grpc-plugins package.
- protoc/Dockerfile: install protoc 26.1 from official GitHub release for code generation; keep Alpine's protoc 24.4 as protoc-system for plugin compilation against protobuf-dev headers - protoc-cpp/build.sh: use protoc-system for wire_options regeneration; add temporary sed patch for proto3 optional support (remove once s12-proto PR #155 is merged) - publish.sh: revert -pre tag bypass for protoc/protoc-cpp images - docs: add migration notes for protoc 1.15.0 and protoc-cpp 1.13.0
protoc-cpp depends on the protoc base image being published first. Split into a follow-up PR after protoc:1.15.0 is merged and available.
Michael Gunawan (scmichaelg)
changed the title
4 tasks
Michael Gunawan (scmichaelg)
changed the title
Harry Tran (HarryTranAU)
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grpc-pluginspackage, install protoc 26.1 from GitHub release (Alpine's protoc 24.4 kept asprotoc-systemfor plugin compilation)Note: protoc-cpp 1.13.0 changes will be in a follow-up PR after this merges, since protoc-cpp depends on the
protoc:1.15.0base image being published first.Key design decisions
.pb.hfrom protoc 24.4 is incompatible with v26.1 headers. Solution: install protoc 26.1 from official GitHub release as/usr/bin/protoc(used by buf for codegen), keep Alpine's as/usr/bin/protoc-system(needed for compiling plugins againstprotobuf-devheaders).Companion changes (crux repo)
See migration notes for the full list of 17 issues found and fixed during validation.
Follow-up PRs
abseil-cpp-dev/pkgconfdeps,wire_optionsregeneration, proto3 optional patchprotoc-javagrpc-java version (proto3 optional support)Test plan
🤖 Generated with Claude Code