fix(hysteria2): check json.Marshal error in SSE event stream#4168
Open
hklcf wants to merge 1 commit into
Open
Conversation
If ev.data contains values that cannot be serialized by encoding/json, the marshal would silently return empty data, corrupting the SSE stream. Check the error and log it, skipping the event on failure. Fixes SagerNet#4163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In \protocol/hysteria2/realm_server.go:383, the error from \json.Marshal\ is silently discarded with \data, _ := json.Marshal(ev.data). If \ev.data\ contains values that cannot be serialized (e.g., cyclic structures), the SSE stream sends empty data with no error logged.
Fix
Check the error from \json.Marshal, log it, and skip the event to avoid sending corrupted data.
Related Issue
Fixes #4163