Skip to content

fix(daemon): log gRPC Send() errors instead of silencing them #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hklcf wants to merge 1 commit into
base: testing
Choose a base branch
from
+16 −7
Open

fix(daemon): log gRPC Send() errors instead of silencing them #4169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions daemon/started_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,7 +1185,7 @@ func (s *StartedService) StartNetworkQualityTest(
MaxRuntime: time.Duration(request.MaxRuntimeSeconds) * time.Second,
Context: server.Context(),
OnProgress: func(p networkquality.Progress) {
_ = server.Send(&NetworkQualityTestProgress{
if pErr := server.Send(&NetworkQualityTestProgress{
Phase: int32(p.Phase),
DownloadCapacity: p.DownloadCapacity,
UploadCapacity: p.UploadCapacity,
Expand All @@ -1197,7 +1197,9 @@ func (s *StartedService) StartNetworkQualityTest(
UploadCapacityAccuracy: int32(p.UploadCapacityAccuracy),
DownloadRPMAccuracy: int32(p.DownloadRPMAccuracy),
UploadRPMAccuracy: int32(p.UploadRPMAccuracy),
})
}); pErr != nil {
s.WriteMessage(log.LevelError, "send network quality progress: "+pErr.Error())
}
},
})
if nqErr != nil {
Expand Down Expand Up @@ -1245,13 +1247,15 @@ func (s *StartedService) StartSTUNTest(
Dialer: resolvedDialer,
Context: server.Context(),
OnProgress: func(p stun.Progress) {
_ = server.Send(&STUNTestProgress{
if pErr := server.Send(&STUNTestProgress{
Phase: int32(p.Phase),
ExternalAddr: p.ExternalAddr,
LatencyMs: p.LatencyMs,
NatMapping: int32(p.NATMapping),
NatFiltering: int32(p.NATFiltering),
})
}); pErr != nil {
s.WriteMessage(log.LevelError, "send STUN progress: "+pErr.Error())
}
},
})
if stunErr != nil {
Expand Down Expand Up @@ -1323,12 +1327,15 @@ func (s *StartedService) SubscribeTailscaleStatus(
waitGroup.Add(1)
go func(tag string, provider adapter.TailscaleEndpoint) {
defer waitGroup.Done()
_ = provider.SubscribeTailscaleStatus(ctx, func(endpointStatus *adapter.TailscaleEndpointStatus) {
subErr := provider.SubscribeTailscaleStatus(ctx, func(endpointStatus *adapter.TailscaleEndpointStatus) {
select {
case updates <- taggedStatus{tag: tag, status: endpointStatus}:
case <-ctx.Done():
}
})
if subErr != nil {
s.WriteMessage(log.LevelError, "subscribe Tailscale status: "+subErr.Error())
}
}(endpoint.tag, endpoint.provider)
}

Expand Down Expand Up @@ -1459,14 +1466,16 @@ func (s *StartedService) StartTailscalePing(
}

return provider.StartTailscalePing(server.Context(), request.PeerIP, func(result *adapter.TailscalePingResult) {
_ = server.Send(&TailscalePingResponse{
if pErr := server.Send(&TailscalePingResponse{
LatencyMs: result.LatencyMs,
IsDirect: result.IsDirect,
Endpoint: result.Endpoint,
DerpRegionID: result.DERPRegionID,
DerpRegionCode: result.DERPRegionCode,
Error: result.Error,
})
}); pErr != nil {
s.WriteMessage(log.LevelError, "send Tailscale ping response: "+pErr.Error())
}
})
}

Expand Down