vfio/pci: fix segfault when running without an IOMMU - #70
Open
iomartin wants to merge 1 commit into
Open
Conversation
iomartin
force-pushed
the
martin/no_iommu
branch
from
August 17, 2026 15:17
bae4474 to
0ae99a9
Compare
Contributor
|
I assume this is with a tainted kernel with CONFIG_VFIO_NOIOMMU set? Might be worth mentioning that in the commit message because "IOMMU disabled" was not immediately obvious to me. |
Contributor
Author
|
No, I hit it when I tried to run in a machine that had |
If IOMMU is disabled (such as with iommu=off in the cmdline), iommu_get_ctx() returns NULL, and then the following line tries to dereference the context, causing a segfault. Signed-off-by: Martin Oliveira <martin.oliveira@eideticom.com>
iomartin
force-pushed
the
martin/no_iommu
branch
from
August 19, 2026 16:59
0ae99a9 to
da7a006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If IOMMU is disabled, iommu_get_ctx() returns NULL, and then the following line tries to dereference the context, causing a segfault.