Fix: "No document to update" / "Document already exists" failed-Commit audit entries

[PaulGoldschmidt]

"No document to update" / "Document already exists" failed-Commit audit entries

♻️ Current situation & Problem

This PR disables deleteHealthSamples.js, which has contributed a lot of "No document to update" / "Document already exists" failed-Commit audit entries and can be disabled while we work on improving the general data pipeline.

⚙️ Release Notes

N/A

📚 Documentation

N/A

✅ Testing

N/A

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• I agree to follow the Code of Conduct and Contributing Guidelines.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b481b673-286d-4d89-8ee9-3b7413f97ffa

📥 Commits

Reviewing files that changed from the base of the PR and between 20c9b7a and 23aafbc.

📒 Files selected for processing (1)

• functions/src/index.ts

---

📝 Walkthrough

Walkthrough

The re-export of the deleteHealthSamples function is commented out in the functions index entrypoint to temporarily prevent Firestore audit-log spam. The function is not removed, only disabled from deployment.

Changes

Disable Health Sample Deletion Exports

Layer / File(s)	Summary
Disable deleteHealthSamples export functions/src/index.ts	The re-export of deleteHealthSamples.js is commented out with an explanatory note that it is temporarily disabled to stop Firestore audit-log spam.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• StanfordBDHG/MyHeartCounts-Firebase#183: Changes deleteHealthSamples logging that relates directly to the disabled callable.
• StanfordBDHG/MyHeartCounts-Firebase#141: Updates the deleteHealthSamples handler implementation and tests that this PR disables from deployment.
• StanfordBDHG/MyHeartCounts-Firebase#176: Modifies health-sample deletion processing logic connected to the disabled function.

Suggested reviewers

• PSchmiedmayer
• lukaskollmer

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the problem being fixed: eliminating audit log spam from failed-Commit entries, which aligns with the changeset that disables deleteHealthSamples.js.
Description check	✅ Passed	The description clearly explains the current situation, the problem with deleteHealthSamples.js causing audit spam, and the solution of temporarily disabling it.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/logging-reducements-v2

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

functions/src/index.ts

Oops! Something went wrong! :(

ESLint: 9.39.2

Error: Could not serialize processor object (missing 'meta' object).
at Config.toJSON (/node_modules/eslint/lib/config/config.js:495:10)
at stringify (/node_modules/json-stable-stringify-without-jsonify/index.js:25:25)
at module.exports (/node_modules/json-stable-stringify-without-jsonify/index.js:68:7)
at hashOfConfigFor (/node_modules/eslint/lib/cli-engine/lint-result-cache.js:56:42)
at LintResultCache.getValidCachedLintResults (/node_modules/eslint/lib/cli-engine/lint-result-cache.js:159:24)
at LintResultCache.getCachedLintResults (/node_modules/eslint/lib/cli-engine/lint-result-cache.js:110:30)
at lintFile (/node_modules/eslint/lib/eslint/eslint-helpers.js:1279:40)
at /node_modules/eslint/lib/eslint/eslint.js:632:25
at Array.map ()
at lintFilesWithoutMultithreading (/node_modules/eslint/lib/eslint/eslint.js:628:13)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[PSchmiedmayer]

Probably only want to merge this once the iOS release is out there and we have a significant amount of users on the new version. Then we can disable the old logic and cloud function here ...