update SpeziStudy

[lukaskollmer]

update SpeziStudy

⚙️ Release Notes

• updates to new SpeziStudy release

📚 Documentation

n/a

✅ Testing

todo

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• I agree to follow the Code of Conduct and Contributing Guidelines.

[coderabbitai]

Warning

Rate limit exceeded

@lukaskollmer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 26 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 04334f61-ef3c-408b-8cd3-0c274e8cd24d

📥 Commits

Reviewing files that changed from the base of the PR and between 2d7dd84 and c7293dd.

📒 Files selected for processing (1)

• Package.swift

📝 Walkthrough

Walkthrough

Bump Swift package dependencies and migrate the MHC study metadata to locale-keyed dictionaries; incremented studyRevision from 38 to 39 and added SpeziLocalization import.

Changes

Study definitions & packaging

Cohort / File(s)	Summary
Package dependency updates Package.swift	Updated SpeziStudy constraint from 0.1.19 → 0.2.2 and SpeziFoundation from 2.4.0 → 2.7.7.
Study definition localization Sources/MHCStudyDefinitionExporter/Study.swift	Added import SpeziLocalization; changed title, shortTitle, shortExplanationText and explanationText to locale-keyed dictionaries (.enUS); removed explicit enrollmentConditions and bumped studyRevision 38 → 39.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• StanfordBDHG/MyHeartCounts-StudyDefinitions#30: Also modifies SpeziStudy dependency declaration in Package.swift.

Suggested reviewers

• PSchmiedmayer
• PaulGoldschmidt

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'update SpeziStudy' is vague and generic, using a non-descriptive term that doesn't convey meaningful information about the changeset beyond a general package update.	Consider a more specific title that describes the actual changes, such as 'Update SpeziStudy and SpeziFoundation dependencies' or 'Localize study metadata and update dependencies'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is related to the changeset as it mentions updates to a new SpeziStudy release, which aligns with the dependency version updates in Package.swift.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch lukas/updates

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

Sources/MHCStudyDefinitionExporter/Study.swift (1)

11-17: ⚠️ Potential issue | 🟡 Minor

Fix import order to satisfy SwiftLint.

Line 17 introduces a sorted-imports violation reported by CI.

Suggested import order

 import Foundation
 import MHCStudyDefinition
 import SpeziHealthKit
 import enum SpeziHealthKitBulkExport.ExportSessionStartDate
+import SpeziLocalization
 import SpeziScheduler
 import SpeziStudyDefinition
-import SpeziLocalization

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Sources/MHCStudyDefinitionExporter/Study.swift` around lines 11 - 17, The
imports in Study.swift are out of order and trigger SwiftLint's sorted-imports
rule; reorder the import statements (import Foundation, import
MHCStudyDefinition, import SpeziHealthKit, import enum
SpeziHealthKitBulkExport.ExportSessionStartDate, import SpeziScheduler, import
SpeziStudyDefinition, import SpeziLocalization) into the canonical sorted order
required by the project/SwiftLint (typically alphabetical by module name,
keeping the `import enum ...` form adjacent to its module) so that SwiftLint no
longer reports a sorted-imports violation.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Package.swift`:
- Around line 30-31: The manifest currently pins the SpeziFoundation dependency
by branch ("lukas/LocalizationsDict-init") which makes builds non-reproducible;
update the .package entry referencing
"https://github.com/StanfordSpezi/SpeziFoundation.git" to use a stable tag
(e.g., from: "2.7.5") or, if you truly need an unreleased branch commit, pin the
exact git revision (commit SHA) instead of branch: to ensure deterministic
resolution for the .package(...) entry in Package.swift.

---

Outside diff comments:
In `@Sources/MHCStudyDefinitionExporter/Study.swift`:
- Around line 11-17: The imports in Study.swift are out of order and trigger
SwiftLint's sorted-imports rule; reorder the import statements (import
Foundation, import MHCStudyDefinition, import SpeziHealthKit, import enum
SpeziHealthKitBulkExport.ExportSessionStartDate, import SpeziScheduler, import
SpeziStudyDefinition, import SpeziLocalization) into the canonical sorted order
required by the project/SwiftLint (typically alphabetical by module name,
keeping the `import enum ...` form adjacent to its module) so that SwiftLint no
longer reports a sorted-imports violation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b33f830-4440-4114-8259-5c11196809ef

📥 Commits

Reviewing files that changed from the base of the PR and between a84f12d and 43c23c3.

📒 Files selected for processing (2)

• Package.swift
• Sources/MHCStudyDefinitionExporter/Study.swift

[PSchmiedmayer]

Looks good once the SwiftLint & tagged releases are there. We need to definitely test on staging if this doesn't crash the old app or causes any other issues (shouldn't be the case as far as I understand) before pushing anything out to production. Plus we should ensure that we get the new MHC version to production in the App Store first (test that this works with the old study bundles in a backwards compatible manner) and then push this out to production?