Conversation
| end | ||
| # check stopping criterion | ||
| iter > 1 && (η = θ / (1 - θ)) | ||
| if ndw < κ && (iter > 1 || iszero(ndw) || !iszero(integrator.success_iter)) |
Member
There was a problem hiding this comment.
should η be used here? If you look at the equivalent condition (see e.g. the OrdinaryDiffEQFIRK version of this loop).
xbtmkmmm5
force-pushed
the
fix/taylor-series-implicit
branch
from
September 21, 2026 17:42
39a5c2f to
3f9271b
Compare
| distance = -μ * dt | ||
| end | ||
| local ndw | ||
| # reusing η is causing problems, temporarily initialize it to Inf |
Member
There was a problem hiding this comment.
is this comment still accurate?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.