Logging for isoutofdomain and add interface for domain_checks - #4114
Open
Shreyas-Ekanathan wants to merge 3 commits into
Open
Shreyas-Ekanathan wants to merge 3 commits into
Shreyas-Ekanathan wants to merge 3 commits into
Conversation
Comment on lines
+555
to
+556
| * `domain_checks`: Specifies a vector of predicates, each `(u,p,t) -> Bool` or | ||
| `(u,p,t) -> Pair{Bool,<:AbstractString}` (to attach a custom message), checked |
Member
There was a problem hiding this comment.
This can have function wrapping issues? Why not require the user supplies the struct instead?
Contributor
Author
There was a problem hiding this comment.
that would work but has heavy user-side implications right? realistically a user doesn't want to supply the struct.
an alternative that is cleanly function wrapped would be to wrap the function in these domain checks prior to function wrapping itself happening, which is then stable throughout. This is a fairly complicated change though, I've scoped it out and pushed it so we can choose if we like this. Let me know your thoughts, I'm open to changes here since this is a big design choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does three things:
Some code examples:
domain_checks and logging:
isoutofdomain and logging: