New Algorithm SharpFineRKN6 (see: https://github.com/SciML/OrdinaryDiffEq.jl/issues/677) - #4567
Open
HenryLangner wants to merge 5 commits into
Open
HenryLangner wants to merge 5 commits into
HenryLangner wants to merge 5 commits into
Conversation
…ked the order conditions with the coefficients. Everything looks good.
Contributor
Author
|
The OrdinaryDiffEqRKN [QA] check failed with an Aqua error about not being able to locate ChainRulesCore this does not seem related to my changes however I can not re-run the test. Can someone do that? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
I have ran the JuliaFormatter so the formatting should be fine. And all code guidelines should be fulfilled however a short review would be appreciated just to make sure that the code follows all guidlines.
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
New RKN Algorithm SharpFineRKN6 based on Some Nyström pairs for the general second-order initial-value problem.
I have attached a test file (test_SharpFineRKN6.txt, *.txt since *.jl is not supported for upload) for the Algorithm which does all the tests found in lib/OrdinaryDiffEqRKN/test/nystrom_convergence_tests.jl. The output is the following:
Some thoughts: All, besides three, tests pass. The first test which does not pass is the vector harmonic one. Here the l2 order is too low. The same phenomena can be observed for higher order RKN-Solvers (where machine precision is hit to fast. See: DPRKN12 big float test). Therefor I have added a big float test which passes. The second and third failing test is the adaptive IIP vs OOP one. However this is a phenomena already observed for this type of solvers see FineRKN4 adaptive IIP vs OOP tests. Nothing to worry about here. All in all everything looks as expected.