Skip to content

Add non_exhaustive to enums#896

Merged
tyt2y3 merged 2 commits into
masterfrom
non_exhaustive
Jun 8, 2025
Merged

Add non_exhaustive to enums#896
tyt2y3 merged 2 commits into
masterfrom
non_exhaustive

Conversation

@tyt2y3

@tyt2y3 tyt2y3 commented Jun 8, 2025

Copy link
Copy Markdown
Member

cont'd #891

Huliiiiii and others added 2 commits June 8, 2025 20:48
* Add `non_exhaustive` to `SimpleExpr`

* Add `non_exhasutive` to more enum

- func::Function
- types::{ColumnRef, TableRef, UnOper, BinOper, Keyword, SubQueryOper}
- value::{Value, ValueTuple}
- extension::mysql::column::MySqlType
- extension::postgres::func::PgFunction
- extension::postgres::PgBinOper
- extension::postgres::select::SampleMethod
- extension::postgres::types::TypeAs
- extension::sqlite::SqliteBinOper

* Add `non_exhasutive` to more enum

* Add helper functions
@tyt2y3

tyt2y3 commented Jun 8, 2025

Copy link
Copy Markdown
Member Author

It seems like we only have to remove non_exhaustive from Value. I think that's fine, because additional value type support has always been feature gated.

@tyt2y3 tyt2y3 merged commit f80b01a into master Jun 8, 2025
20 checks passed
@tyt2y3 tyt2y3 deleted the non_exhaustive branch June 8, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants