chore(lints): deny correctness/suspicious and enable clippy::all - #9
Merged
Conversation
The workspace denied the panic pair (`unwrap_used`/`expect_used`) but ran the
rest of clippy at `pedantic` warn only — the `all` group and the two
defect-class denies (`correctness`, `suspicious`) were absent, so a genuine
correctness lint would have rendered as a warning at most. This brings the
manifest to the fleet-canonical set (CLAUDE.core.md, "Rust Lint Posture").
The individual allows move from bare `"allow"` to `{ level = "allow",
priority = 1 }`. That is required, not cosmetic: clippy's
`lint_groups_priority` rejects a manifest where a denied group shares
priority 0 with an individual lint, and priority 1 is also what makes the
allows actually outrank the grouped entries.
Zero new diagnostics: `cargo clippy --all-targets --workspace -- -D warnings`
is clean after a forced rebuild, and the test suite passes unchanged.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
h4x0r
marked this pull request as ready for review
August 5, 2026 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes
[workspace.lints.clippy]to the fleet-canonical set (CLAUDE.core.md→ "Rust Lint Posture"):all = { level = "warn", priority = -1 }correctness = { level = "deny", priority = -1 }suspicious = { level = "deny", priority = -1 }"allow"to{ level = "allow", priority = 1 }Why
The repo already denied
unwrap_used/expect_used, but everything else ran atpedanticwarn only — so a genuinecorrectnessfinding would have rendered as a warning at most. This is part of a fleet-wide sweep; the same shaped gap in sibling repos concealed a release-mode i64 overflow, a public-API panic, and a 16 GiB unbounded allocation from an untrusted length field.The priority change is load-bearing, not cosmetic: clippy's
lint_groups_priorityrejects a manifest where a denied group shares priority 0 with an individual lint, and priority 1 is what makes the allows actually outrank the grouped entries.Verification
Config-only change — zero sites lit up. Verified after
touching the crate roots so this is a real recompile, not a cache hit:Scope note
Effective per-member configuration was checked, not just the root — every member inherits via
[lints] workspace = truewith no member-local[lints.clippy]table that would silently replace inheritance.🤖 Generated with Claude Code