Skip to content

chore(lints): complete the canonical workspace lint set with clippy::all - #6

Draft
h4x0r wants to merge 1 commit into
mainfrom
lints/workspace-lints-sweep
Draft

chore(lints): complete the canonical workspace lint set with clippy::all#6
h4x0r wants to merge 1 commit into
mainfrom
lints/workspace-lints-sweep

Conversation

@h4x0r

@h4x0r h4x0r commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

What

Adds all = { level = "warn", priority = -1 } to [workspace.lints.clippy], completing the fleet-canonical lint set (CLAUDE.core.md → "Rust Lint Posture").

Why

This repo already denied correctness, suspicious, unwrap_used and expect_used, but the all group was never enabled — so clippy's style, complexity and perf lints outside the pedantic set were silently off. This is part of a fleet-wide sweep; the same shaped gap in other repos concealed a release-mode i64 overflow, a public-API panic, and a 16 GiB unbounded allocation from an untrusted length field.

Verification

Config-only change — zero sites lit up.

$ cargo clippy --all-targets --workspace -- -D warnings
    Finished `dev` profile [unoptimized + debuginfo] target(s)
$ cargo fmt --check      # clean
$ cargo build --workspace # clean
$ cargo test --workspace  # all suites pass, 0 failed

Diff is one line in the root Cargo.toml.

Scope note

Effective per-member configuration was checked, not just the root — every member inherits via [lints] workspace = true with no member-local [lints.clippy] table that would silently replace inheritance.

🤖 Generated with Claude Code

The workspace already denied `correctness`/`suspicious` and the panic pair
(`unwrap_used`/`expect_used`), but never enabled the `all` group — so the
style/complexity/perf lints outside `pedantic` were silently off. Adding it
brings the manifest to the fleet-canonical set (CLAUDE.core.md, "Rust Lint
Posture").

Zero new diagnostics: `cargo clippy --all-targets --workspace -- -D warnings`
is clean, and the full test suite passes unchanged.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant