chore(lints): complete the canonical workspace lint set with clippy::all - #6
Draft
h4x0r wants to merge 1 commit into
Draft
chore(lints): complete the canonical workspace lint set with clippy::all#6h4x0r wants to merge 1 commit into
h4x0r wants to merge 1 commit into
Conversation
The workspace already denied `correctness`/`suspicious` and the panic pair (`unwrap_used`/`expect_used`), but never enabled the `all` group — so the style/complexity/perf lints outside `pedantic` were silently off. Adding it brings the manifest to the fleet-canonical set (CLAUDE.core.md, "Rust Lint Posture"). Zero new diagnostics: `cargo clippy --all-targets --workspace -- -D warnings` is clean, and the full test suite passes unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
all = { level = "warn", priority = -1 }to[workspace.lints.clippy], completing the fleet-canonical lint set (CLAUDE.core.md→ "Rust Lint Posture").Why
This repo already denied
correctness,suspicious,unwrap_usedandexpect_used, but theallgroup was never enabled — so clippy'sstyle,complexityandperflints outside thepedanticset were silently off. This is part of a fleet-wide sweep; the same shaped gap in other repos concealed a release-mode i64 overflow, a public-API panic, and a 16 GiB unbounded allocation from an untrusted length field.Verification
Config-only change — zero sites lit up.
Diff is one line in the root
Cargo.toml.Scope note
Effective per-member configuration was checked, not just the root — every member inherits via
[lints] workspace = truewith no member-local[lints.clippy]table that would silently replace inheritance.🤖 Generated with Claude Code