-
Notifications
You must be signed in to change notification settings - Fork 208
[AMD] Add MiniMax-M3-FP4 MI355X ATOM EAGLE3 / non-EAGLE3 update 0623 #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seungrokj
wants to merge
18
commits into
main
Choose a base branch
from
amd/m3_atom_single_fp4_0623
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+142
−33
Open
Changes from 6 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6a1a203
[AMD] add MiniMax-M3 FP8 MI355X ATOM single-node benchmark script
seungrokj 03f5752
[AMD] add minimaxm3-fp8-mi355x-atom recipe and bump atom image to 202…
seungrokj a245590
[AMD] add perf-changelog entry for minimaxm3-fp8-mi355x-atom
seungrokj 25b8fab
[AMD] include minimaxm3-fp8-mi355x-atom-mtp in perf-changelog entry
seungrokj 0e1a9e4
[AMD] add minimaxm3-fp4-mi355x-atom-mtp and bump atom image to 20260623
seungrokj c3d8c1f
[AMD] add perf-changelog entry for minimaxm3-fp4-mi355x-atom-mtp
seungrokj d799dd5
[AMD] revert minimaxm3-fp4-mi355x-atom-mtp image to MiniMax-M3-20260622
seungrokj 2c2bf37
[AMD] remove minimaxm3_fp8_mi355x_atom.sh from fp4 branch (belongs to…
seungrokj a5c9f29
[AMD] remove fp8 atom perf-changelog entry from fp4 branch (belongs t…
seungrokj ce65d9a
[AMD] remove minimaxm3-fp8-mi355x-atom-mtp recipe from fp4 branch (be…
seungrokj 266c375
[AMD] rename minimaxm3-fp8-mi355x-atom recipe to atom-mtp with spec-d…
seungrokj ec2d464
[AMD] swap SPEC_ARGS between fp4 atom and atom-mtp scripts
seungrokj b649691
[AMD] enable AITER_QUICK_REDUCE_QUANTIZATION=INT4 when CONC < 256 for…
seungrokj 82b1909
[AMD] enable AITER_QUICK_REDUCE_QUANTIZATION=INT4 and disable fp8 kv …
seungrokj adf9696
[AMD] enable AITER_QUICK_REDUCE_QUANTIZATION=INT4 unconditionally and…
seungrokj 7ec070f
Merge branch 'main' into amd/m3_atom_single_fp4_0623
seungrokj 5edce27
[AMD] restore CONC < 256 condition for AITER_QUICK_REDUCE_QUANTIZATIO…
seungrokj a922012
[AMD] drop tp=2 search-space entries and enable AITER_QUICK_REDUCE_QU…
seungrokj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
benchmarks/single_node/fixed_seq_len/minimaxm3_fp4_mi355x_atom_mtp.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| source "$(dirname "$0")/../../benchmark_lib.sh" | ||
|
|
||
| check_env_vars \ | ||
| MODEL \ | ||
| TP \ | ||
| CONC \ | ||
| ISL \ | ||
| OSL \ | ||
| RANDOM_RANGE_RATIO \ | ||
| RESULT_FILENAME \ | ||
| EP_SIZE \ | ||
| DP_ATTENTION | ||
|
|
||
| if [[ -n "$SLURM_JOB_ID" ]]; then | ||
| echo "JOB $SLURM_JOB_ID running on $SLURMD_NODENAME" | ||
| fi | ||
|
|
||
| echo "TP: $TP, CONC: $CONC, ISL: $ISL, OSL: $OSL, EP_SIZE: $EP_SIZE, DP_ATTENTION: $DP_ATTENTION" | ||
|
|
||
| SERVER_LOG=/workspace/server.log | ||
|
|
||
| PARALLEL_ARGS=(-tp "$TP") #TP | ||
| if [ "$DP_ATTENTION" = "true" ]; then | ||
| if [ "$EP_SIZE" -gt 1 ]; then #DP+EP | ||
| PARALLEL_ARGS=(-tp "$TP" --enable-expert-parallel --enable-dp-attention ) | ||
| else #DP+TP | ||
| PARALLEL_ARGS=(-tp "$TP" --enable-dp-attention ) | ||
| fi | ||
| fi | ||
|
|
||
| SPEC_ARGS=() | ||
|
|
||
| # Start GPU monitoring (power, temperature, clocks every second) | ||
| start_gpu_monitor | ||
| MEM_FRAC_STATIC=0.8 | ||
|
|
||
| set -x | ||
| #export AITER_QUICK_REDUCE_QUANTIZATION=INT4 | ||
| export ATOM_M3_SPARSE_USE_ASM_PA=1 | ||
| export MAX_MODEL_LEN=32768 | ||
| export MAX_NUM_BATCHED_TOKENS=32768 | ||
| export MAX_NUM_SEQS=256 | ||
| python3 -m atom.entrypoints.openai_server \ | ||
| --model $MODEL \ | ||
| --server-port $PORT \ | ||
| "${PARALLEL_ARGS[@]}" \ | ||
| "${SPEC_ARGS[@]}" \ | ||
| --block-size 128 \ | ||
| --gpu-memory-utilization $MEM_FRAC_STATIC \ | ||
| --max-model-len $MAX_MODEL_LEN \ | ||
| --max-num-batched-tokens $MAX_NUM_BATCHED_TOKENS \ | ||
| --max-num-seqs $MAX_NUM_SEQS \ | ||
| --kv_cache_dtype fp8 \ | ||
| --trust-remote-code \ | ||
| --no-enable_prefix_caching \ | ||
| > $SERVER_LOG 2>&1 & | ||
|
|
||
| SERVER_PID=$! | ||
|
|
||
| # Wait for server to be ready | ||
| wait_for_server_ready --port "$PORT" --server-log "$SERVER_LOG" --server-pid "$SERVER_PID" | ||
|
|
||
| export PYTHONDONTWRITEBYTECODE=1 | ||
| run_benchmark_serving \ | ||
| --model "$MODEL" \ | ||
| --port "$PORT" \ | ||
| --backend vllm \ | ||
| --input-len "$ISL" \ | ||
| --output-len "$OSL" \ | ||
| --random-range-ratio "$RANDOM_RANGE_RATIO" \ | ||
| --num-prompts "$((CONC * 10))" \ | ||
| --max-concurrency "$CONC" \ | ||
| --result-filename "$RESULT_FILENAME" \ | ||
| --result-dir /workspace/ \ | ||
| --trust-remote-code $( [[ ${#SPEC_ARGS[@]} -gt 0 ]] && echo "--use-chat-template" ) | ||
|
|
||
| # After throughput, run evaluation only if RUN_EVAL is true | ||
| if [ "${RUN_EVAL}" = "true" ]; then | ||
| run_eval --framework lm-eval --port "$PORT" | ||
| append_lm_eval_summary | ||
| fi | ||
|
|
||
| # Stop GPU monitoring | ||
| stop_gpu_monitor | ||
| set +x |
87 changes: 87 additions & 0 deletions
87
benchmarks/single_node/fixed_seq_len/minimaxm3_fp8_mi355x_atom.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| source "$(dirname "$0")/../../benchmark_lib.sh" | ||
|
|
||
| check_env_vars \ | ||
| MODEL \ | ||
| TP \ | ||
| CONC \ | ||
| ISL \ | ||
| OSL \ | ||
| RANDOM_RANGE_RATIO \ | ||
| RESULT_FILENAME \ | ||
| EP_SIZE \ | ||
| DP_ATTENTION | ||
|
|
||
| if [[ -n "$SLURM_JOB_ID" ]]; then | ||
| echo "JOB $SLURM_JOB_ID running on $SLURMD_NODENAME" | ||
| fi | ||
|
|
||
| echo "TP: $TP, CONC: $CONC, ISL: $ISL, OSL: $OSL, EP_SIZE: $EP_SIZE, DP_ATTENTION: $DP_ATTENTION" | ||
|
|
||
| SERVER_LOG=/workspace/server.log | ||
|
|
||
| PARALLEL_ARGS=(-tp "$TP") #TP | ||
| if [ "$DP_ATTENTION" = "true" ]; then | ||
| if [ "$EP_SIZE" -gt 1 ]; then #DP+EP | ||
| PARALLEL_ARGS=(-tp "$TP" --enable-expert-parallel --enable-dp-attention ) | ||
| else #DP+TP | ||
| PARALLEL_ARGS=(-tp "$TP" --enable-dp-attention ) | ||
| fi | ||
| fi | ||
|
|
||
| SPEC_ARGS=() | ||
|
|
||
| # Start GPU monitoring (power, temperature, clocks every second) | ||
| start_gpu_monitor | ||
| MEM_FRAC_STATIC=0.8 | ||
|
|
||
| set -x | ||
| #export AITER_QUICK_REDUCE_QUANTIZATION=INT4 | ||
| export ATOM_M3_SPARSE_USE_ASM_PA=1 | ||
| export MAX_MODEL_LEN=32768 | ||
| export MAX_NUM_BATCHED_TOKENS=32768 | ||
| export MAX_NUM_SEQS=256 | ||
| python3 -m atom.entrypoints.openai_server \ | ||
| --model $MODEL \ | ||
| --server-port $PORT \ | ||
| "${PARALLEL_ARGS[@]}" \ | ||
| "${SPEC_ARGS[@]}" \ | ||
| --block-size 128 \ | ||
| --gpu-memory-utilization $MEM_FRAC_STATIC \ | ||
| --max-model-len $MAX_MODEL_LEN \ | ||
| --max-num-batched-tokens $MAX_NUM_BATCHED_TOKENS \ | ||
| --max-num-seqs $MAX_NUM_SEQS \ | ||
| --kv_cache_dtype fp8 \ | ||
| --trust-remote-code \ | ||
| --no-enable_prefix_caching \ | ||
| > $SERVER_LOG 2>&1 & | ||
|
|
||
| SERVER_PID=$! | ||
|
|
||
| # Wait for server to be ready | ||
| wait_for_server_ready --port "$PORT" --server-log "$SERVER_LOG" --server-pid "$SERVER_PID" | ||
|
|
||
| export PYTHONDONTWRITEBYTECODE=1 | ||
| run_benchmark_serving \ | ||
| --model "$MODEL" \ | ||
| --port "$PORT" \ | ||
| --backend vllm \ | ||
| --input-len "$ISL" \ | ||
| --output-len "$OSL" \ | ||
| --random-range-ratio "$RANDOM_RANGE_RATIO" \ | ||
| --num-prompts "$((CONC * 10))" \ | ||
| --max-concurrency "$CONC" \ | ||
| --result-filename "$RESULT_FILENAME" \ | ||
| --result-dir /workspace/ \ | ||
| --trust-remote-code $( [[ ${#SPEC_ARGS[@]} -gt 0 ]] && echo "--use-chat-template" ) | ||
|
|
||
| # After throughput, run evaluation only if RUN_EVAL is true | ||
| if [ "${RUN_EVAL}" = "true" ]; then | ||
| run_eval --framework lm-eval --port "$PORT" | ||
| append_lm_eval_summary | ||
| fi | ||
|
|
||
| # Stop GPU monitoring | ||
| stop_gpu_monitor | ||
| set +x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.