Add MiniMax-M3 NVFP4 B300 Dynamo vLLM benchmarks#1931
Conversation
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. 感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致 如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow 一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。 如需更多帮助,PR 作者可通过 Slack 联系核心维护者。 |
|
Claude finished @Oseltamivir's task in 2m 47s —— View job PR Review: MiniMax-M3 NVFP4 B300 Dynamo vLLM
LGTM — no blocking issues found. Verified in detail:
|
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28165689371 |
There was a problem hiding this comment.
LGTM — benchmark-only addition that mirrors the existing MiniMax-M3 MXFP8 B300 setup with a parallel NVFP4 path.
Extended reasoning...
Overview
This PR adds a new MiniMax-M3 NVFP4 B300 disaggregated Dynamo-vLLM benchmark sweep. The changes are scoped entirely to benchmark infrastructure: 15 new srt-slurm recipe YAMLs under benchmarks/multi_node/srt-slurm-recipes/vllm/minimax-m3/b300-fp4/, a new minimax-m3-nvfp4-vllm-fixes.sh setup script that overlays vllm-project/vllm#46380 at a pinned commit and re-applies the MSA contiguous top-k patch, a new minimaxm3-fp4-b300-dynamo-vllm sweep entry in nvidia-master.yaml, a corresponding perf-changelog.yaml entry, and a small runners/launch_b300-nv.sh extension that adds the new minimaxm3 + fp4 + dynamo-vllm branch and selects the right setup script per precision.
Security risks
None. The added curl-downloads pin a specific upstream commit hash (6c08558112acd2fd8b4bfc270104d556eb77f9bf) and the script runs in the benchmark worker context only. No auth, crypto, permission, or user-input paths are touched.
Level of scrutiny
Low. The changes follow the established MXFP8 pattern almost verbatim — same topology matrix, same recipe shape, same runner branching style. The launch_b300-nv.sh edits are a mechanical extension of an existing conditional chain that already supported minimaxm3 + fp8. The NVFP4 fixes script mirrors the existing minimax-m3-vllm-fixes.sh flow.
Other factors
The PR description reports passing matrix-logic and changelog-gate tests (180 + 20 passed), shellcheck, and YAML/bash-syntax validation. The bug hunting system found no issues. The author tag is full-sweep-enabled so CI will exercise the new sweep. Nothing here warrants holding for a human reviewer.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28165689371 |
Summary
minimaxm3-fp4-b300-dynamo-vllmfor B300 disaggregated Dynamo-vLLM STP coverage at 1k1k and 8k1knvidia/MiniMax-M3-NVFP4from the staged/scratch/models/MiniMax-M3-NVFP4path and the B300 performance image used by PR Add MiniMax-M3 NVFP4 B300 single-node aggregated vLLM benchmark #19286c08558112acd2fd8b4bfc270104d556eb77f9bfduring worker setupValidation
uv run --with pytest --with pydantic --with pyyaml python -m pytest utils/matrix_logic/ -q(180 passed)uv run --with pytest --with pydantic --with pyyaml python -m pytest utils/changelog_gate_tests/test_validate_perf_changelog.py -q(20 passed)spec-decoding: nonegit diff --check