Skip to content

fix: CI running old swift doesnt match concurrency warnings #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kieran-osgood-shopify merged 1 commit into from
Mar 25, 2026
Merged

fix: CI running old swift doesnt match concurrency warnings #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

swiftformat:
name: SwiftFormat & SwiftLint
runs-on: macos-15
runs-on: macos-26
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- run: |
Expand All @@ -26,14 +26,14 @@ jobs:

check-license-headers:
name: License Headers
runs-on: macos-latest
runs-on: macos-26
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- run: ./Scripts/ensure_license

lint-podspec:
name: CocoaPods
runs-on: macos-15
runs-on: macos-26
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: ruby/setup-ruby@dffb23f65a78bba8db45d387d5ea1bbd6be3ef18 # v1.293.0
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ on:

jobs:
test:
runs-on: macos-15
runs-on: macos-26
timeout-minutes: 20

steps:
- name: Checkout Repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Switch to Xcode 16.4
- name: Switch to Xcode 26.2
run: |
sudo xcode-select --switch /Applications/Xcode_16.4.app
sudo xcode-select --switch /Applications/Xcode_26.2.app
echo ""

- name: Display Current Xcode Path
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
- name: Create Test Simulator
run: |
echo "🔧 Creating new test simulator..."
CURRENT_SIMULATOR_UUID=$(xcrun simctl create TestDevice "iPhone 16")
CURRENT_SIMULATOR_UUID=$(xcrun simctl create TestDevice "iPhone 17 Pro")
echo "✅ Created simulator with UUID: $CURRENT_SIMULATOR_UUID"
echo "CURRENT_SIMULATOR_UUID=$CURRENT_SIMULATOR_UUID" >> $GITHUB_ENV
echo ""
Expand Down
4 changes: 3 additions & 1 deletion ...s/MobileBuyIntegration/MobileBuyIntegration/Generated/Schema/SchemaMetadata.graphql.swift
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ up:
- jq
- ruby
- xcode:
version: "26.0"
version: "26.2"
runtimes:
ios:
- "26.0"
- version: 23C54 # 26.2
architecture_variant: arm64
- custom:
name: Ensure Storefront.xcconfig file
met?: |
Expand Down
Loading