feat: re-write to remove deprecated apollo syntax#544
Closed
kieran-osgood-shopify wants to merge 4 commits intokieran-osgood/03-25-featbumpapollotov2from
Closed
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 25, 2026
Upgrade sample apps to Apollo v2 and re-run code generation. Apollo v1 generated code caused Swift 6 concurrency issues, so the generated GraphQL fragments and operations were regenerated with the v2 generator (formatting/structure changes only). The Xcode project references were updated to remove obsolete generated entries and align with the new code layout. This change removes the temporary workaround and enables the 2025-07 Swift upgrade / follow-up PR to proceed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Previous PR bumped to apollo v2 but didn't resolve deprecation warnings
This PR replaces deprecated v1 apollo apis with their v2 equivalent
Apollo v2 gives native async/await support and concurrency handling, meaning we can remove the wrappers like withCheckedThrowingContinuation
Before you merge
Important
Releasing a new version of the kit?
podspecfile.Releasing a new major version?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.