Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/create-homebrew-pr.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {Liquid} from 'liquidjs'
const require = createRequire(import.meta.url)
const {readFile, mkdir, lstat, copy, outputFile, pathExists, rm} = require('fs-extra')
const {program} = require('commander')
const colors = require('ansi-colors')
const colors = {green: (s) => `\x1b[32m${s}\x1b[39m`, bold: (s) => `\x1b[1m${s}\x1b[22m`}
import {withOctokit} from './github-utils.js'

const packagingDirectory = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../packaging")
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"@types/node": "18.19.70",
"@typescript-eslint/parser": "8.56.1",
"@vitest/coverage-istanbul": "^3.1.4",
"ansi-colors": "^4.1.3",
"bugsnag-build-reporter": "^2.0.0",
"commander": "^9.4.0",
"esbuild": "0.27.4",
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 11 additions & 9 deletions workspace/src/lint.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ import * as path from 'pathe'
import fg from 'fast-glob'
import * as url from 'url'
import {promises as fs} from 'fs'
import {createRequire} from 'module'

const require = createRequire(import.meta.url)
const colors = require('ansi-colors')
const ansi = {
bold: (s) => `\x1b[1m${s}\x1b[22m`,
dim: (s) => `\x1b[2m${s}\x1b[22m`,
green: Object.assign((s) => `\x1b[32m${s}\x1b[39m`, {bold: (s) => `\x1b[1m\x1b[32m${s}\x1b[39m\x1b[22m`}),
red: Object.assign((s) => `\x1b[31m${s}\x1b[39m`, {bold: (s) => `\x1b[1m\x1b[31m${s}\x1b[39m\x1b[22m`}),
}

const rootDirectory = path.join(url.fileURLToPath(new URL('.', import.meta.url)), '../..')
let exitCode = 0
Expand All @@ -21,7 +23,7 @@ let exitCode = 0
* often in the Javascript ecosystem than in others due to the deep nature of dependency graphs and the
* lack of automated testing in projects.
*/
console.info(colors.green.bold(`Linting that packages have strict version requirements`))
console.info(ansi.green.bold(`Linting that packages have strict version requirements`))
const packageJsonPaths = await fg(path.join(rootDirectory, 'packages/*/package.json'), {type: 'file'})
const dependenciesWithLooseVersionRequirement = []
const internalPackages = ['@shopify/ui-extensions-dev-console-app']
Expand All @@ -40,13 +42,13 @@ for (const packageJsonPath of packageJsonPaths) {

if (dependenciesWithLooseVersionRequirement.length !== 0) {
exitCode = 1
console.error(colors.red.bold(`The following dependencies have dependencies with loose version requirements:`))
console.error(colors.dim(`Loose version requirements might result in broken installations on the user end`))
console.error(ansi.red.bold(`The following dependencies have dependencies with loose version requirements:`))
console.error(ansi.dim(`Loose version requirements might result in broken installations on the user end`))
for (const dependency of dependenciesWithLooseVersionRequirement) {
console.error(
` - ${colors.bold('Package')}: ${dependency.pkg} | ${colors.bold('Dependency')}: ${
` - ${ansi.bold('Package')}: ${dependency.pkg} | ${ansi.bold('Dependency')}: ${
dependency.dependency
} | ${colors.bold('Version')}: ${dependency.version}`,
} | ${ansi.bold('Version')}: ${dependency.version}`,
)
}
}
Expand Down
9 changes: 2 additions & 7 deletions workspace/src/utils/log.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
import {createRequire} from 'module'

const require = createRequire(import.meta.url)
const colors = require('ansi-colors')

export function logSection(title) {
console.info(colors.green.bold(title))
console.info(`\x1b[1m\x1b[32m${title}\x1b[39m\x1b[22m`)
}

export function logMessage(message) {
console.info(colors.gray(` ${message}`))
console.info(`\x1b[90m ${message}\x1b[39m`)
}
Loading