fix: update section type in config/settings_data.json on section rename#1193
Open
reza6ix wants to merge 1 commit intoShopify:mainfrom
Open
fix: update section type in config/settings_data.json on section rename#1193reza6ix wants to merge 1 commit intoShopify:mainfrom
reza6ix wants to merge 1 commit intoShopify:mainfrom
Conversation
Author
|
I signed the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #713. When a section file is renamed in a Shopify theme, the
typeattributeinside
config/settings_data.jsonpresets was not updated, leaving the file pointingat the old section name
Template files, section groups, and
{% section %}tags were already handled bySectionRenameHandler;settings_data.jsonwas the only missing location.Changes
src/utils/uri.ts— addsisSettingsDataURI predicatesrc/renamed/handlers/utils.ts— addsSettingsDatainterfaces andisValidSettingsDatatype guardsrc/renamed/handlers/SectionRenameHandler.ts— addsgetSettingsDataChangesmethodsrc/renamed/handlers/SectionRenameHandler.spec.ts— 4 new testsOnly the
typeattribute value is updated; section keys and all other fields are untouched.Test plan
yarn testinpackages/theme-check-common— 946 tests passyarn testinpackages/theme-language-server-common— 437 tests pass