Skip to content

[2.1] Bots - reduce session writes #9126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbulen wants to merge 8 commits into
base: release-2.1
Choose a base branch
from
+10 −1
Open

[2.1] Bots - reduce session writes #9126

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0d54578
Minimize unnecessary session writes
sbulen Feb 23, 2026
3c802aa
Minimize unnecessary session writes
sbulen Mar 13, 2026
e67ec80
Minimize unnecessary session writes
sbulen Mar 13, 2026
570441a
Merge remote-tracking branch 'upstream/release-2.1' into 21_bot_sessions
sbulen Apr 11, 2026
0819410
Minimize unnecessary session writes
sbulen Apr 11, 2026
c93f6f0
Align cookie secure setting with SMF setting; Leverage PHP lazy_write
sbulen Apr 11, 2026
ef9d271
Align cookie secure setting with SMF setting; Leverage PHP lazy_write
sbulen Apr 11, 2026
eac5f3c
Align cookie secure setting with SMF setting
sbulen Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Sources/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ function loadSession()
@ini_set('session.use_cookies', true);
@ini_set('url_rewriter.tags', '');
@ini_set('arg_separator.output', '&');
@ini_set('session.lazy_write', true);
@ini_set('session.cookie_secure', empty($modSettings['secureCookies'] ? false : true));
Comment thread
sbulen marked this conversation as resolved.
Outdated

// Allows mods to change/add PHP settings
call_integration_hook('integrate_load_session');
Expand Down Expand Up @@ -172,12 +174,19 @@ public function read(/*PHP 8.0 string*/$id)/*PHP 8.0: string|false*/
#[\ReturnTypeWillChange]
public function write(/*PHP 8.0 string*/$id,/*PHP 8.0 string */ $data): bool
{
global $smcFunc;
global $smcFunc, $scripturl, $context, $modSettings;
// Any action that is not dependent on data within the session may be added to this array
static $no_writes = array('dlattach');

// Don't bother writing the session if cookies are disabled; no way to retrieve it later
if (empty($_COOKIE))
return true;

// Don't bother writing the session for users just browsing
// If verification is required, always write the session
if ((empty($_REQUEST['action']) || in_array($_REQUEST['action'], $no_writes, true)) && !empty($scripturl) && empty($context['require_verification']) && !empty($modSettings['allow_guest_access']))
return true;

if (!$this->isValidSessionID($id))
return false;

Expand Down
Loading