Replace url-parse with WHATWG URL in core and content#464
Open
patelti4 wants to merge 3 commits intoSitecore:devfrom
Open
Replace url-parse with WHATWG URL in core and content#464patelti4 wants to merge 3 commits intoSitecore:devfrom
patelti4 wants to merge 3 commits intoSitecore:devfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR replaces direct
url-parseusage in@sitecore-content-sdk/coreand@sitecore-content-sdk/contentwith the WHATWGURLAPI.Motivation:
DEP0169warnings for legacyurl.parse()behaviorpackages/core/src/graphql-request-client.tspackages/content/src/media/media-api.tsalso usedurl-parse, so this removes the remaining first-party usage in the affected packagesurl-parseREADME notes that the package predates broad WHATWGURLsupport and says to “consider using it for better security and accuracy”Changes:
packages/core/src/graphql-request-client.tswith WHATWGURLpackages/content/src/media/media-api.tsto use WHATWGURLwhile preserving relative URL behaviorurl-parseand@types/url-parsedependencies frompackages/coreandpackages/contentTesting Details
Manual/other validation included running root-level lint, tests, API surface verification, and build checks, plus package-level test runs for
@sitecore-content-sdk/coreand@sitecore-content-sdk/content.Validation run from the monorepo root:
yarn lint-packagesyarn test-packagesyarn api-extractor:verifyyarn buildAdditional package-level validation:
yarn workspace @sitecore-content-sdk/core testyarn workspace @sitecore-content-sdk/content testTypes of changes