Skip to content

BYOC and FEAAS are broken when client component map generation is disabled#467

Open
sc-nikolaoslazaridis wants to merge 3 commits intodevfrom
fix/JSS-8762
Open

BYOC and FEAAS are broken when client component map generation is disabled#467
sc-nikolaoslazaridis wants to merge 3 commits intodevfrom
fix/JSS-8762

Conversation

@sc-nikolaoslazaridis
Copy link
Copy Markdown
Contributor

@sc-nikolaoslazaridis sc-nikolaoslazaridis commented May 6, 2026

Description / Motivation

Running component map generation in App router with clientComponentMap set to false was using incorrect component wrappers in the generated component-map.ts. This PR fixes this bug by using the correct <...ServerWrapper> components.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

📦 Package Size and Test Coverage Report

Package Base Size PR Size Δ Change Base Coverage PR Coverage Δ Change
analytics-core 67.34 KB 67.34 KB ✅ 0.00 KB 97.40% 97.40% 0.00%
cli 59.14 KB 59.14 KB ✅ 0.00 KB 70.09% 70.09% 0.00%
content 425.31 KB 425.31 KB ✅ 0.00 KB 92.27% 92.27% 0.00%
core 120.38 KB 120.38 KB ✅ 0.00 KB 91.25% 91.25% 0.00%
create-content-sdk-app 336.21 KB 336.21 KB ✅ 0.00 KB 96.35% 96.35% 0.00%
events 72.27 KB 72.27 KB ✅ 0.00 KB 97.97% 97.97% 0.00%
nextjs 508.01 KB 508.95 KB 🔺 +0.94 KB 91.10% 90.78% -0.31%
personalize 64.01 KB 64.01 KB ✅ 0.00 KB 99.74% 99.74% 0.00%
react 230.78 KB 230.78 KB ✅ 0.00 KB 93.80% 93.80% 0.00%
search 8.10 KB 8.10 KB ✅ 0.00 KB 98.57% 98.57% 0.00%
Total 🔺 +0.94 KB

@MenKNas
Copy link
Copy Markdown
Contributor

MenKNas commented May 6, 2026

LGTM! Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants