Skip to content

[NO-JIRA] Surface Percy silent failures as CI errors #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Richard-Shen (RichardSyq) wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[NO-JIRA] Surface Percy silent failures as CI errors #4541

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91c36d9
[NO-JIRA][CI] Surface Percy silent failures as CI errors
May 22, 2026
311ac15
Merge branch 'main' into RichardSyq/percy-silent-failure-analysis
RichardSyq May 22, 2026
3d57ab1
Merge branch 'main' into RichardSyq/percy-silent-failure-analysis
RichardSyq May 22, 2026
22620a8
[NO-JIRA][CI] Use PERCY_RAISE_ERROR instead of fragile log grep
May 22, 2026
7e332fd
[NO-JIRA][CI] Replace PERCY_RAISE_ERROR with log-based failure detection
May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,17 @@ jobs:
key: ${{ env.BUILD_CACHE_NAME }}-${{ hashFiles('packages/backpack-web/**', 'libs/backpack-storybook-utils/**', 'libs/backpack-storybook-host/**') }}

- name: Percy Test
run: npm run percy-test
if: ( github.ref == 'refs/heads/main' || github.repository == github.event.pull_request.head.repo.full_name) && github.actor != 'dependabot[bot]'
env:
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
run: |
set -o pipefail
if [ -z "$PERCY_TOKEN" ]; then
echo "::error::PERCY_TOKEN is not set or empty"
exit 1
fi
npm run percy-test 2>&1 | tee /tmp/percy.log
if grep -q "\[percy\] Build not created" /tmp/percy.log; then
echo "::error::Percy build was not created — check token validity and Percy service status"
exit 1
fi
Loading