Conversation
art0007i
requested review from
ButterscotchV,
Eirenliel,
Erimelowo,
ImSapphire and
loucass003
as code owners
github-actions
Bot
added
Area: Application Protocol
| if (this.duration < 1f) { | ||
| this.duration = 1f | ||
| } | ||
| if (this.duration > 1000000000000000f) { |
There was a problem hiding this comment.
the idea was that it's a floating point setting which is being multiplied by 1000 and turned into a "Long", so I put an upper bound to prevent potential overflow
There was a problem hiding this comment.
maybe, but if it was a long, it would be in ms, which I think typing values in milliseconds in the ui would be weird.
I could make it so the server stores the number as a long, and the gui uses floats but performs all of the conversion before sending it, but from what I understand the solarxr stuff allows other apps to also listen to the same messages, in which case receiving a time in seconds as a float is 'nicer' than milliseconds as a long in my opinion
|
This doesn't seem to actually implement the functionality. |
It just modifies the default behavior which is 2 seconds of no data = tracker is timed out, 5 seconds of no data = tracker is disconnected. I made the time when the tracker is timed out but not disconnected adjustable, so I can set it to like a million and my trackers will never show up as disconnected, only timed out, which is what was suggested in the issue. |
| <Input | ||
| type="number" | ||
| control={control} | ||
| name="timeout.duration" | ||
| label="" | ||
| min={1} | ||
| max={1000000000000000} | ||
| step="any" | ||
| /> |
There was a problem hiding this comment.
why not use a NumberSelector?
There was a problem hiding this comment.
I want to be able to type into it
Co-authored-by: Sapphire <imsapphire0@gmail.com>
|
what does "SolarXR PR found but no change on the submodule." mean on the failing check? |
|
It got merged so it is probably just confused now, since the merged pr is still linked on this pr |
|
if no done already you need to point solarxr to main |
5 participants
Resolves #1505
SolarXR-Protocol pr: SlimeVR/SolarXR-Protocol#201