Warn when an orbit fit fails on a sub-24h arc (#312)#335
Open
matthewholman wants to merge 1 commit into
Open
Conversation
Orbit determination needs an observational baseline longer than ~24 hours. When a fit fails on a single night of data the user previously got an opaque failure. Now, on a failed fit, _orbitfit checks the observation arc span and, if it is under a day, logs a clear warning naming the object and the (too short) arc length so the likely cause is obvious. Implemented as a small _warn_if_short_arc helper (threshold _MIN_ARC_DAYS = 1.0 day) called where the fit result is known to have failed. Adds unit tests for the sub-day (warns), multi-day (silent), and empty (no crash) cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Orbit determination needs an observational baseline longer than ~24 hours. When a fit failed on a single night of data, the user previously got an opaque failure (issue #312).
On a failed fit,
_orbitfitnow checks the observation arc span and, if it is under a day, logs a clear warning naming the object and the (too-short) arc length so the likely cause is obvious.Changes
_warn_if_short_arc(jds, obj_id)helper (threshold_MIN_ARC_DAYS = 1.0day), called where the fit result is known to have failed.Verification
test_orbit_fit.py: 9 passed on a fresh build, including the 3 new tests.Closes #312.
🤖 Generated with Claude Code