Skip to content

feat(localization): allow strings to be localized from the main bundle #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ReasonB wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(localization): allow strings to be localized from the main bundle #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
523e1b9
feat(localization): open strings to be localized from the main bundle
Jun 20, 2025
adc82bd
Update LocalizedString.swift
ReasonB Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Sources/SCSDKCameraKitReferenceUI/Localization/LocalizedString.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,16 @@ public func CameraKitLocalizedString(
table: String? = nil
) -> String {
let resolvedBundle = bundle ?? bestBundle(forPreferredLanguages: preferredLanguages)
let mainBundle = bundle ?? Bundle.main
let fallbackBundle = bestBundle(forPreferredLanguages: ["en-US"])
let mainBundleResolvedString = mainBundle.localizedString(forKey: key, value: nil, table: table)
let resolvedString = resolvedBundle.localizedString(forKey: key, value: nil, table: table)
let fallbackString = fallbackBundle.localizedString(forKey: key, value: nil, table: table)

if mainBundleResolvedString != key {
// The requested string has been localized in the main bundle.
return mainBundleResolvedString
}
if resolvedString == key, fallbackString != key {
// The localizedString call for the specified bundle returned the key (ie: it hasn't been localized) but the English bundle doesn't.
// This indicates that the requested string has not been localized, and we should fall back to the English value instead of showing the user the key.
Expand Down