Cleaning up dependencies with cargo-machette#2743
Draft
theodorebugnet wants to merge 3 commits intodevfrom
Draft
Cleaning up dependencies with cargo-machette#2743theodorebugnet wants to merge 3 commits intodevfrom
theodorebugnet wants to merge 3 commits intodevfrom
Conversation
1459f59 to
e721dbe
Compare
490a924 to
94ed591
Compare
94ed591 to
8ce7668
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
0d9766d to
a62c602
Compare
CI setup action doesn't have it so it can't be added to `make lint` yet.
a62c602 to
6fbb59b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our makefile's
install-dev-toolssection installs cargo-udeps, but it seems broken because it requires a nightly compiler and it breaks sp1 crates when I tried it.This PR replaces it with
cargo machete, which is must faster and works fine, except it has a lot of false positives. Codex worked for some hours in the background adding[package.metadata.cargo-machete]sections to Cargo.toml files where necessary to get everything to compile again.Net changes:
[package.metadata.cargo-machete]noise added to many Cargo.toml filescargo machetecan run in CI for the future (once we update the Namespace base image)I have updatedCHANGELOG.mdwith a new entry if my PR makes any breaking changes or fixes a bug. If my PR removes a feature or changes its behavior, I provide help for users on how to migrate to the new behavior.Cargo.tomlchanges before opening the PRs. (Are all new dependencies necessary? Is any module dependency leaked into the full-node (hint: it shouldn't)?)Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?
Rendered docs are available at
https://sovlabs-ci-rustdoc-artifacts.us-east-1.amazonaws.com/<BRANCH_NAME>/index.html