fix: remove conflicting index command registrations - #416
Open
emecii wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restore CLI startup after duplicate
index-*subparser registrations were merged in9b786b0.LeannCLI.create_parser()currently raisesargparse.ArgumentError: conflicting subparser: index-browserbefore any command can run, including help and list.Remove the seven duplicate registrations and shadowed handlers introduced from #269, retaining the implementation from #285, which explicitly superseded it. All 68 effective non-parser methods remain unchanged. Keep the established
--max-count,--index-name, and recomputation behavior; update two documentation examples to match.Related Issues
Follow-up to the integration of #269 and #285. This also removes the seven baseline F811 errors visible in #415, but contains none of its tokenizer changes.
Validation
This restores startup and the previously accepted behavior. It does not resolve the pre-existing standalone-wheel reader packaging gap (
apps.*is absent), implement stub readers, or change reader limits and platform support. Real personal-data ingestion, native vector builds, the full test suite, and cross-platform CI were not run locally.Checklist
uv run pytest; focused validation and exclusions are above.pre-commit run --all-filespasses.Implemented and tested with Codex assistance. No claim of personal human review is made.