feat(eval): add regional MiniMax metadata - #142
Merged
ASuresh0524 merged 2 commits intoAug 30, 2026
Merged
Conversation
|
@octo-patch is attempting to deploy a commit to the andylizf's projects Team on Vercel. A member of the Team first needs to authorize it. |
Follow-ups to StarTrail-org#142, on top of it. The regional endpoint selection works; these are the two edges around it. - An unsupported MINIMAX_API_REGION was rejected before the endpoint overrides were applied, so a deployment that pinned both MINIMAX_API_BASE and MINIMAX_ANTHROPIC_API_BASE still had to name a region from a list it was not using. The README offers those two as independent overrides for gateways and proxies; now they are. A region is consulted, and therefore validated, only when at least one base was left unset. - The metadata splat indexed MINIMAX_MODEL_METADATA directly, so registering a model in MINIMAX_MODELS without also adding a capability entry raised KeyError for every caller of that model. The two dicts have nothing keeping them in sync. The registry is now what decides whether a model resolves, and the side table is optional — which costs nothing, since run_bench.py (the only consumer) reads api_base, api_key and model, never the metadata. The metadata values themselves are left exactly as they are. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: Refresh MiniMax evaluation configuration with selectable regional endpoints and current model metadata.
Summary
MINIMAX_API_REGIONwhile preserving independent overridesChecks
uv run pytest tests/test_eval_model_config.py -quv run python -m py_compile eval/lib/model_config.py tests/test_eval_model_config.py