Conversation
|
@Stanley-Owoh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slippage-Protection | Maximum Slippage Tolerance Enforcement
Protect users from sandwich attacks and market volatility by enforcing minimum payout thresholds on swap outputs.
Changes
New files:
src/amm/mod.rs— Module declaration for the AMM subsystemsrc/amm/slippage.rs— Core slippage enforcement logic withenforce_slippage(amount_out, min_amount_out)functionModified files:
src/lib.rs— Addedpub mod amm;andContractError::SlippageExceeded = 47error variantDetails
The
enforce_slippagefunction validates the final calculated output against the caller'smin_amount_outparameter. Ifamount_out < min_amount_out, the transaction aborts withContractError::SlippageExceeded, reverting all state changes and preventing the user from receiving less than their specified minimum.Includes seven unit tests covering pass/fail conditions, boundary cases, zero values, and large values.
Closes #601