feat: implement secure remittance escrow with explicit auth verification (#718) - #895
Merged
Conversation
|
@Naajih09 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a secure, cross-border remittance escrow contract. The
implementation focuses on Soroban's native authentication framework to ensure
that funds can only be moved or claimed by authorized participants, mitigating
the risk of unauthorized state manipulation.
Changes Made
creation. This ensures the contract only transfers tokens if the
transaction is signed by the legitimate owner of the funds.
settlement phase. Funds can only be released if the intended recipient
provides a valid signature.
tracking active escrows.
the recipient claims the funds.
include (symbol_short!("created"), sender, recipient).
(symbol_short!("claimed"), recipient).
claimed to optimize ledger space and reduce rent costs.
Technical Implementation Details
checking env.invoker(), ensuring compatibility with smart wallet accounts
and future-proofing the contract.
off-chain indexing.
Acceptance Criteria Verification
release.
Closes #718