Fix ten bugs from a random sweep of libse/libuilogic - #14025
Merged
Conversation
Convert actors (Name: source): color was computed and discarded, every cut was indexed into the untrimmed line so leading whitespace mangled the text, and the "to Actor field" path dropped the name instead of setting p.Actor. IsActor also rejected "Mr."/"Dr." before its own title allowance could run. Fix casing: "I-if" -> "I-If " inserted a double space; FixStutter's bounds were one too strict so a stutter at the very end of a line was never fixed. Unknown 33/34/59 writers rounded seconds without carrying, emitting ":60". KaraokeWordTransform overshot by one after whitespace so a tag following a space was split on its inner space. The OCR multi-guess loop never tried the last position of a word. LoadMatroskaSSA crashed on a Dialogue payload with too few commas. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A random bug hunt across libse/libuilogic; every item was reproduced with a failing test before being fixed (tests in
tests/libse/Core/BugHunt20260823Test.cs).Convert actors (
Name:source) —ActorConverter.FixActorsFromBeforeColonSetColor(...)result was discarded.startIdxcame from the raw line but all cuts were on the trimmed one (" Joe: How…"→"Joe:: ow…"; more spaces threw).p.Actornever set; view model now copies it across too.Mr./Mrs./Dr.allowance inIsActorwas dead — the non-letter guard ran first and rejected the period.Fix casing
I-if→I-If␣␣inserted a double space.FixStutterbounds were one too strict, soN-n-noat the end of a line was never fixed.Other
00:00:60for 59.6 s (rounded seconds without carrying).KaraokeWordTransformskipped one char past whitespace, so a tag right after a space (<font face="Arial">) was split on its inner space.CreateGuessesFromLettersmulti-guess loop used<instead of<=, never trying the last position of a word (the sibling loop above it already used<=).LoadMatroskaSSAthrew on a Dialogue payload with fewer commas than expected.Verification
🤖 Generated with Claude Code