Skip to content

Fix OpenRouter STT requests for GPT transcription models - #14028

Merged
niksedk merged 2 commits into
SubtitleEdit:mainfrom
muaz978:codex/openrouter-transcribe-json
Aug 24, 2026
Merged

Fix OpenRouter STT requests for GPT transcription models#14028
niksedk merged 2 commits into
SubtitleEdit:mainfrom
muaz978:codex/openrouter-transcribe-json

Conversation

@muaz978

@muaz978 muaz978 commented Aug 23, 2026

Copy link
Copy Markdown

Summary

  • Use json for GPT transcription models that reject verbose_json.
  • Omit timestamp granularity hints for those models.
  • Keep verbose timestamp responses for Whisper-compatible models.
  • Add request-body coverage for the supported GPT transcription model IDs.

Testing

  • dotnet test tests/UI/UITests.csproj --no-restore --filter FullyQualifiedName~OpenRouterSttServiceTests -p:UsedAvaloniaProducts=
  • dotnet test tests/UI/UITests.csproj --no-restore -p:UsedAvaloniaProducts=

Both test runs pass.

@muaz978

muaz978 commented Aug 23, 2026

Copy link
Copy Markdown
Author

@niksedk Quick note: I’ve added a fix for OpenRouter STT requests with GPT transcription models in this PR. These models reject verbose_json, so the patch switches them to json and keeps the existing verbose and timestamp path for Whisper models. The focused OpenRouter tests and the full UI test suite pass. Please take a look when you have a moment.

@muaz978

muaz978 commented Aug 23, 2026

Copy link
Copy Markdown
Author

Working now!

image

gpt-*-transcribe was matched via three hardcoded substrings, so a
future model like gpt-5-transcribe would silently fall back to
verbose_json and fail the same way this PR fixes. Match on the
gpt-*-transcribe name shape instead.
@niksedk
niksedk merged commit 3f908eb into SubtitleEdit:main Aug 24, 2026
1 check passed
@niksedk niksedk mentioned this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants