Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request significantly expands the SwanLab SDK's API coverage by implementing wrappers for experiment management, project operations, user settings, and self-hosted deployment configurations. It also introduces supporting utility functions and comprehensive type definitions for improved static analysis. Review feedback focuses on refining status code validation for API responses, optimizing filter processing using the walrus operator, correcting duplicate field definitions in TypedDicts, and improving type hint coverage for utility functions.
SAKURA-CAT
requested changes
Apr 21, 2026
SAKURA-CAT
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Legacy的 API 层,service与save的分线程上传对象存储的逻辑未接入,但保留 uploadId 转换等工具函数