Task/wc 332 add project admin to dpmp#1327
Open
van-go wants to merge 8 commits into
Open
Conversation
Add project admin group functionality and related client access checks - Introduced `check_project_admin_group` and `get_project_client` functions to manage project admin access. - Updated various views to utilize the new client access logic for project admins. - Enhanced project metadata handling to include project admin group checks. - Added unit tests for project admin group functionality and client retrieval.
…rkspace and its members
jarosenb
approved these changes
Jun 30, 2026
jarosenb
left a comment
jarosenb
left a comment
Contributor
There was a problem hiding this comment.
These changes look good- I'm approving but I want to hold off on merging until we can deploy to PPRD and check out the edge cases we ran into in the last testing session.
shayanaijaz
reviewed
Jun 30, 2026
shayanaijaz
requested changes
Jun 30, 2026
shayanaijaz
left a comment
shayanaijaz
left a comment
Contributor
There was a problem hiding this comment.
Added a comment for changes to a function
shayanaijaz
reviewed
Jul 13, 2026
shayanaijaz
left a comment
shayanaijaz
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Not merging at the moment since we are going to be deploying this branch for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Prevents client.files.grantPermissions / client.files.deletePermissions from being called with the wma_prtl service account when Tapis requires the actual system owner.
When a Project Admin creates a new workspace, their username is passed as the Tapis system owner, so later owner-only actions can work for that workspace.
Related
Changes
Testing
UI
Notes