-
Notifications
You must be signed in to change notification settings - Fork 1
task/WI-454 - DPM Merge into Main #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f5becf8
6136154
d1b16a5
8eb1c0a
c504a91
5c0c98c
23cd979
c1b8072
7f93454
f6bf61d
1611b6f
1dbb304
0e5319a
ea5e6ca
9c5543c
5f7f8b9
4f5a310
933ea44
5eafb87
6e19162
941a2d2
e79c3be
1754f24
9b7e8e3
404971f
a2d3fd7
c414dde
e536d7b
efee296
de6d2e1
3a92605
859baf1
dcc3967
f9697ef
b533ff6
271ce8c
c3dfa00
7787b4a
761c23d
ae6dffa
c746fb2
cd9f844
bf07c6a
1a7a491
7add4a0
056b184
6a9e8e9
9e6ea01
4b1df92
b6b0399
ba5bef9
0cfa7c7
b357d90
599bf67
292ccc0
8570360
14b2127
9a35429
1ee184b
7cac920
7a2520b
952bf8c
f1e6001
b58bbdc
c0eb836
6e8b2ab
a804e37
7aa05c9
5057ebb
5dfbe9e
bbb217b
65f4ecf
055e5d5
c0c12c9
ed00e39
2657744
eac5544
66396ce
b82c745
92ef96c
fbaed5a
176f3e4
1d12cf5
b0b3358
1fda663
2e19e3b
a04ef5b
2e85945
eab4ba2
54177d1
caa8fd5
0e5ee06
71ba1f4
6f8445f
fac0564
85f4241
2e947ff
5089ccc
ab6bb83
7dfc0d5
58f3435
33b1ecd
f3e8314
1f8617b
4bb5bcd
d89f00f
cbee444
456a1b5
5a6178e
8f3dcb5
b74e3f5
2a4878c
4f41234
b7f7ccd
4872483
ef843e4
105a019
310751f
05783b6
3633214
c9002f1
7f9bc18
0c7ca89
a821a0c
eb83abc
1b82d7d
4bc15fd
b49edd2
0b45158
ab79328
884836d
2e1b2e4
22f92d3
d081218
5883750
d6d93d5
c60cea4
d36f626
8f82afa
0034125
d67eab0
9713b78
6316c78
9a99276
44a50d8
c55701f
dbc7332
752ff28
3bbb0fe
d8204dd
321114e
3e74eac
1c71f9c
4612b9f
e5b1f84
ae9bd6f
761a049
78876ab
87b0c49
3985dee
298ee1b
a7a8b68
62165bf
6c68a7f
8b1580e
9d91f42
0fb454f
84cb02c
340aa6a
81e4472
b20d66b
9c4211e
54bfbd8
6b25211
ba02c41
67d3bb8
775934d
7f943cd
5b666d0
e16ff02
16f5fa0
d02e3c1
0a307e8
85c88b3
268e5db
d4f1d5b
eee0ac9
1125c2c
39274ff
56d73df
3a6e8c3
b6159da
60d4531
2839ed3
b4b8045
dedfd9d
aacade5
fde28e9
25b3f8e
75aa9cc
b946716
fee970c
3727e63
55d2a66
cf62123
3785efe
d7508a2
aac147f
2006637
aa8f23c
46e6e34
765db44
167bc79
d13e7a3
2432e15
fcaa747
3afa719
d3a7f4a
225b800
20416eb
96fb000
0f95f20
2cf1fec
22caa24
eeb38ac
acc9cab
1139132
29ebf4b
d8737d8
953a6ac
3d34bc5
84caef6
31349a9
400f8e8
7b02774
78a1cfd
1cb3cd9
25ca03b
b06c8b5
142dddc
8c25bd9
363d7ef
9d25647
f03feb9
2273c87
84c95f2
0d15f6d
5a67abe
06b4405
a7bdc51
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we'll want to decide which of these styles we want to go with, since it will change the portals across the board. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -141,7 +141,7 @@ const DataFilesBreadcrumbs = ({ | |
| }); | ||
| }; | ||
|
|
||
| const { fetchSelectedSystem } = useSystems(); | ||
| const { fetchSelectedSystem, isRootProjectSystem } = useSystems(); | ||
|
|
||
| const selectedSystem = fetchSelectedSystem({ scheme, system, path }); | ||
|
|
||
|
|
@@ -183,9 +183,7 @@ const DataFilesBreadcrumbs = ({ | |
| <div className="breadcrumb-container"> | ||
| <div className={`breadcrumbs ${className}`}> | ||
| {currentDirectory.length === 0 ? ( | ||
| <span className="system-name"> | ||
| {truncateMiddle(systemName || 'Shared Workspaces', 30)} | ||
| </span> | ||
| <span className="system-name">{truncateMiddle(systemName, 30)}</span> | ||
| ) : ( | ||
| currentDirectory.map((pathComp, i) => { | ||
| if (i === fullPath.length - 1) { | ||
|
|
@@ -194,11 +192,13 @@ const DataFilesBreadcrumbs = ({ | |
| }) | ||
| )} | ||
| </div> | ||
| {systemName && api === 'tapis' && ( | ||
| <Button type="link" onClick={openFullPathModal}> | ||
| View Full Path | ||
| </Button> | ||
| )} | ||
| {systemName && | ||
| api === 'tapis' && | ||
| !isRootProjectSystem(selectedSystem ?? '') && ( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why wouldn't we want the view full path button to be enabled at root? |
||
| <Button type="link" onClick={openFullPathModal}> | ||
| View Full Path | ||
| </Button> | ||
| )} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note as good candidate to replace with new core-components